[PATCH] D146728: [utils] Give git a dummy email address when cherry picking.

[Roy Sundahl via Phabricator via llvm-commits]

rsundahl added a comment.

In D146728#4235579 <https://reviews.llvm.org/D146728#4235579>, @XiaodongLoong wrote:

> Why we need a dummy address? Did you met any issues?

Yes. The cherry pick failed because git wanted an email address for the commit. Since the commit is an anonymous commit in a container, I chose to provide an anonymous email address.

In D146728#4235613 <https://reviews.llvm.org/D146728#4235613>, @thetruestblue wrote:

> Can you just do
>
>   git cherry-pick -n
>
> aka no commit? shouldn't require an email?

It's true that adding -n will avoid the commit, but doing so would be a functional change (leaving uncommitted changes in the working directory). This might not matter but it's more appropriate to anonymize the email address (since it's an owner-less docker image) and keeping the functionality as it is.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146728/new/

https://reviews.llvm.org/D146728