[PATCH] D146762: [Verifier] Ban GEP, load, store of addrspace(8) on AMDGPU

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 31 08:10:28 PDT 2023


arsenm added a comment.

In D146762#4236828 <https://reviews.llvm.org/D146762#4236828>, @krzysz00 wrote:

> I wasn't sure if the general IR verifier is the absolute best place, but it already has calling-convention specific checks, which, at least in our case, are target specific.

Calling conventions aren't quite the same, even if you always only ever use the calling convention on a specific target in the real world. It's not changing the semantics of a core IR construct based on a target check


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146762/new/

https://reviews.llvm.org/D146762



More information about the llvm-commits mailing list