[PATCH] D147270: [DebugInfo] Support more than 2 operands in DWARF operations

[Orlando Cazalet-Hyams via Phabricator via llvm-commits]

Orlando accepted this revision.
Orlando added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: llvm/include/llvm/DebugInfo/DWARF/DWARFExpression.h:73
+      template <size_t... Is, typename... Ts>
+      constexpr Description(std::index_sequence<Is...>, DwarfVersion Version,
+                            Ts... Ops)
----------------
Possibly worth adding a short comment along the lines of "Fill Op with Ops then Is.size() number of SizeNA entries". YMMV, maybe it's obvious, but it took me a minute to work out what was going on here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147270/new/

https://reviews.llvm.org/D147270