[PATCH] D142888: [compiler-rt] Fix scudo build on ARM

[Leandro Lupori via Phabricator via llvm-commits]

luporl marked an inline comment as done.
luporl added inline comments.


================
Comment at: compiler-rt/lib/scudo/standalone/CMakeLists.txt:157
 
 if (COMPILER_RT_HAS_GWP_ASAN)
   add_dependencies(scudo_standalone gwp_asan)
----------------
hctim wrote:
> Maybe instead, just:
> 
> ```
> set(SCUDO_LINK_LIBS)
> 
> if (COMPILER_RT_HAS_GWP_ASAN)
>   if(COMPILER_RT_USE_LLVM_UNWINDER)
>     list(APPEND SCUDO_LINK_LIBS ${COMPILER_RT_UNWINDER_LINK_LIBS} dl)
>   elseif (COMPILER_RT_HAS_GCC_S_LIB)
>     list(APPEND SCUDO_LINK_LIBS gcc_s)
>   elseif (COMPILER_RT_HAS_GCC_LIB)
>     list(APPEND SCUDO_LINK_LIBS gcc)
>   else()
>     message(FATAL_ERROR "No suitable unwinder library")
>   endif()
> 
>   ... other stuff already in this branch
> endif()
> ```
>   
Just to confirm, is it ok to make this change for all architectures?
Non-ARM32 architectures will start to get an an error when `COMPILER_RT_USE_LLVM_UNWINDER` is OFF and libgcc is not found, even if they don't need to link against an unwind library.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142888/new/

https://reviews.llvm.org/D142888