[PATCH] D143344: [bazel] Port zstd support

[Aaron Siddhartha Mondal via Phabricator via llvm-commits]

aaronmondal added a comment.

Hmm I'm against reverting after all.

This issue is one of the reasons why bzlmod was created in the first place. See https://bazel.build/external/overview#shortcomings_of_the_workspace_system.

Going from there, I think the current workaround is actually the best way forward. It's not pretty, but it seems about as good as it gets with WORKSPACEs. External dependencies *should* be explicitly specified in the workspace file unless we want to adopt a `deps.bzl` pattern which we'd have to remove again when Bazel 7 deprecates WORKSPACEs (also this pattern has been discouraged for a long time now already).

What is currently posted as workaround is probably the best way to handle all external dependencies at the moment and I think this will lead to less friction once we get bzlmod ready.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143344/new/

https://reviews.llvm.org/D143344