[PATCH] D146762: [Verifier] Ban GEP, load, store of addrspace(8) on AMDGPU

[Jay Foad via Phabricator via llvm-commits]

foad added inline comments.


================
Comment at: llvm/lib/IR/Verifier.cpp:3875
 
+  if (TT.isAMDGCN()) {
+    auto *PTy = dyn_cast<PointerType>(GEP.getPointerOperandType());
----------------
It feels wrong to me to have target-dependent checks in the IR verifier, but I don't know if it is actually prohibited.

`TT` crept into the verifier in D65686 as a way to implement object-file-format-dependent checks.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146762/new/

https://reviews.llvm.org/D146762