[PATCH] D147312: [Assignment Tracking][SROA] Handle DIArgList in migrateDebugInfo

[Orlando Cazalet-Hyams via Phabricator via llvm-commits]

Orlando added a comment.

> could you expand the comment

Sure, WDYT of this?

  // If we've updated the value but the original dbg.assign has an arglist
  // then kill it now - we can't use the requested new value.
  // We can't replace the DIArgList with the new value as it'd leave
  // the DIExpression in an invalid state (DW_OP_LLVM_arg operands without
  // an arglist). And we can't keep the DIArgList in case the linked store
  // is being split - in which case the DIArgList + expression may no longer
  // be computing the correct value.
  // This should be a very rare situation as it requires the value being
  // stored to differ from the dbg.assign (i.e., the value has been
  // represented differently in the debug intrinsic for some reason).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147312/new/

https://reviews.llvm.org/D147312