[PATCH] D147306: [InterleaveAccess] Check that binop shuffles have an undef second operand

Fri Mar 31 04:04:20 PDT 2023

dmgreen added a comment.

In D147306#4236258 <https://reviews.llvm.org/D147306#4236258>, @Peter wrote:

> lgtm
>
> One Minor question, what if we have 'shuffle undef, binop, mask', does that mean we don't optimize for such cases?

Thanks - Good question, I will make sure there is a test for it. We would expect that to be transformed by instcombine into `shuffle binop, undef, mask` prior to this pass. If the code had not been canonicalized then we shouldn't do the transform (which will be what happens with this patch, as it will check the second operand is undef).

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147306/new/

https://reviews.llvm.org/D147306