[PATCH] D147310: [Orc] Add AutoRegisterCode option for DebugObjectManagerPlugin

[Stefan Gränitz via Phabricator via llvm-commits]

sgraenitz added a comment.

We don't have versioning of the RPC interface, so adding the `AutoRegisterCode` parameter will be a breaking change. It should show up as a compiler error for clients with customized target process implementations. That makes it obvious and easy to fix (I hope).
Despite of the RPC interface change, I didn't opt for the alternative implementation of configuring the `AutoRegisterCode` setting only once on the executor side. I think it's better to have it as a parameter for the actual RPC call, as this allows the controller to modify the behavior dynamically.

What do you think?



================
Comment at: llvm/lib/ExecutionEngine/Orc/TargetProcess/JITLoaderGDB.cpp:113
              })
       .release();
 }
----------------
@lhames I've never used these alloc actions in practice and just did copy/paste here. Do you think it's ok like this?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147310/new/

https://reviews.llvm.org/D147310