[PATCH] D146612: [Flang][OpenMP][MLIR] Lower OpenMP target attributes

[Kiran Chandramohan via Phabricator via llvm-commits]

kiranchandramohan accepted this revision.
kiranchandramohan added a comment.
This revision is now accepted and ready to land.

LGTM.



================
Comment at: mlir/include/mlir/Dialect/OpenMP/OpenMPOpsInterfaces.td:116
+        Get the Target attribute on the current module if it exists
+        and return the attribute, if it doesn't exit it returns a nullptr
+      }],
----------------



================
Comment at: mlir/include/mlir/Dialect/OpenMP/OpenMPOpsInterfaces.td:128
+        Set the attribute target on the current module with the
+        specified string arguments - name of cpu and corresponind features
+      }],
----------------



CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146612/new/

https://reviews.llvm.org/D146612