[PATCH] D146747: [RISCV] Model select and insertsubvector shuffle kinds

[Luke Lau via Phabricator via llvm-commits]

luke added inline comments.


================
Comment at: llvm/lib/Target/RISCV/RISCVTargetTransformInfo.cpp:299
+    // vslideup.vi  v8, v9, 2
+    return LT.first * getLMULCost(LT.second);
+  case TTI::SK_Select: {
----------------
arcbbb wrote:
> Thanks for implementing this!
> I have a question: LT is from Tp, is it supposed to use SubTp instead of Tp here?
Good point, I'm not sure. Aarch64 seems to SubTp for costing their subvector inserts. Should we be using both legalisation costs?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146747/new/

https://reviews.llvm.org/D146747