[PATCH] D147284: docs: Document procedure for updating pull requests

Thu Mar 30 23:58:47 PDT 2023

jhenderson added inline comments.

================
Comment at: llvm/docs/GitHub.rst:28
+to pull requests in the future.  This section documents the pull request
+policies will be adopting once the project starts using them.
+
----------------

================
Comment at: llvm/docs/GitHub.rst:37-40
+If you choose to do this, you must squash and merge before committing and
+you must use the pull request title and description as the commit message.
+This will allow reviewers to review the commit message before approving the
+commit.
----------------
I agree with the idea of being able to push "fix up" commits to the PR and using Squash & Merge. It might be worth emphasising that the default final commit message will match exactly the PR title and body. I've been known to include additional comments in my initial PR description, to help reviewers, that don't necessarily want to be part of the final commit message, and I'm sure others have too.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147284/new/

https://reviews.llvm.org/D147284