[PATCH] D145658: [Xtensa] Initial support of the ALU operations.

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 30 21:50:42 PDT 2023


MaskRay added a comment.

In D145658#4235601 <https://reviews.llvm.org/D145658#4235601>, @barannikov88 wrote:

> I briefly glanced at the other patches and can't review / accept them without good test coverage.

Agreed. It's convenient to add testsuite as a separate patch, but that's inconvenient for reviewers.
We cannot assess whether some code is dead or not. The tests need to be moved along with functionality changes.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145658/new/

https://reviews.llvm.org/D145658



More information about the llvm-commits mailing list