[PATCH] D146745: [sanitizers] Explainer about dyld and weak overrides on Darwin. (NFC)

[Brittany Blue Gaston via Phabricator via llvm-commits]

thetruestblue accepted this revision.
thetruestblue added a comment.
This revision is now accepted and ready to land.

In D146745#4235114 <https://reviews.llvm.org/D146745#4235114>, @rsundahl wrote:

> Ping - Thank you.

I agree with most of Julian's comments. I think we should pick a "suggested worked around" and use that as an example rather than listing all the options. Those who understand the issue will understand what workarounds need to be added, and those who do not will be provided with a single fix that works, rather than being offered multiple workarounds for something they don't understand.

(When looking at the revision it looks like Julian's edits haven't been addressed cause of the "not done" tag, will you check the boxes of those items that have been completed?)



================
Comment at: llvm/docs/ReleaseNotes.rst:243-247
+      __attribute__((weak)) const char * __asan_default_options(void) {...}
+
+      __attribute__((weak,unused)) unsigned __enableOverrides;
+      
+      __attribute__((weak)) bool unrelatedWeakFlag;
----------------
yln wrote:
> 
I agree with this edit.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146745/new/

https://reviews.llvm.org/D146745