[PATCH] D147221: [LoongArch][NFC] Add tests of additions with immediates (for D147222)

Ben Shi via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 30 18:22:18 PDT 2023


benshi001 marked an inline comment as done.
benshi001 added inline comments.


================
Comment at: llvm/test/CodeGen/LoongArch/ir-instruction/add.ll:719
+; LA64-NEXT:    ret
+  %add = add i32 %x, 4080
+  ret i32 %add
----------------
SixWeining wrote:
> Besides +-4080, it’s better to add tests for the boundary, i.e. [-4096,-2049] or [2048,4094].
All the boundary values are added. Thanks.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147221/new/

https://reviews.llvm.org/D147221



More information about the llvm-commits mailing list