[PATCH] D147212: [ARM] Handle generating SEH unwind info for t2STR_PRE/t2LDR_POST
Martin Storsjö via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Mar 30 14:08:15 PDT 2023
mstorsjo added a comment.
In D147212#4234863 <https://reviews.llvm.org/D147212#4234863>, @efriedma wrote:
> In D147212#4234854 <https://reviews.llvm.org/D147212#4234854>, @mstorsjo wrote:
>
>>> I'm assuming the load/store ops are getting generated by expanding a PUSH/POP, and not some other transform? (So the offset will actually reliably be 4, in practice?)
>>
>> Not sure actually - if looking at the output of `-print-after-all` here, the `t2STR_PRE` appears as such directly, not as a transformation of something else - I don't directly see where it comes from (other than printf instrumenting the code in Target/ARM to see which reference to `t2STR_PRE` gets hit).
>
> Skimming the code, it looks like it's coming out of ARMFrameLowering::emitPushInst... which should be safe in that respect.
Oh, indeed. Thanks for looking into it!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D147212/new/
https://reviews.llvm.org/D147212
More information about the llvm-commits
mailing list