[PATCH] D147260: [Loads] Support SCEVAddExpr as start for pointer AddRec.

Nikita Popov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 30 12:47:01 PDT 2023


nikic requested changes to this revision.
nikic added inline comments.
This revision now requires changes to proceed.


================
Comment at: llvm/lib/Analysis/Loads.cpp:320
+      if (Overflow)
+        return false;
+    }
----------------
Don't you need to check that Offset is also aligned? If I'm reading this right, you'd currently accept Offset = 1 for Alignment = 4, as it is only checked against EltSize and the base pointer.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147260/new/

https://reviews.llvm.org/D147260



More information about the llvm-commits mailing list