[PATCH] D147242: [AMDGPU] Don't bother to use OffsetMode to define Real SMEM instructions

Ivan Kosarev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 30 12:01:08 PDT 2023


kosarev added a comment.

Getting rid of the illusion of possible parameterisation makes sense to me. A follow-up from D146313 <https://reviews.llvm.org/D146313>.

> Various Real multiclasses took an OffsetMode parameter, but only used it to extract the suffix for the name of the corresponding pseudo.

These changed `OffsetMode`-taking entities look more like classes, not multiclasses?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147242/new/

https://reviews.llvm.org/D147242



More information about the llvm-commits mailing list