[PATCH] D146955: [Xtensa] Implement volatile load/store.

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 30 12:00:13 PDT 2023


arsenm added a comment.

Missing tests



================
Comment at: llvm/lib/Target/Xtensa/XtensaISelLowering.cpp:1475
 
+    const MachineMemOperand &MMO = **MI.memoperands_begin();
+    if (MMO.isVolatile()) {
----------------
It's not currently guaranteed that you have a memory operand


================
Comment at: llvm/lib/Target/Xtensa/XtensaISelLowering.cpp:1497
+  case Xtensa::L32I: {
+    const MachineMemOperand &MMO = **MI.memoperands_begin();
+    if (MMO.isVolatile()) {
----------------
It's not currently guaranteed that you have a memory operand


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146955/new/

https://reviews.llvm.org/D146955



More information about the llvm-commits mailing list