[PATCH] D145872: TableGen: Let expressions available to list subscripts and list slices

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/docs/TableGen/ProgRef.rst:527
 
+    *value*\ ``[i,m...n,j,ls]``
+        Each element may be an expression (variables, bang operators).
----------------
This section is indented further than the others 


================
Comment at: llvm/docs/TableGen/ProgRef.rst:530
+        The type of `m` and `n` should be `int`.
+        The tyep of `i`, `j`, and `ls` should be either `int` or `list<int>`.
+
----------------
Typo 'tyep'


================
Comment at: llvm/lib/TableGen/TGParser.cpp:760
+
+  assert(RHS);
+  assert(isa<IntRecTy>(RHS->getType()));
----------------
This assert seems redundant with the cast<> above 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145872/new/

https://reviews.llvm.org/D145872