[PATCH] D147190: [lld][WebAssembly] Process stub libraries before and after LTO

Sam Clegg via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 30 11:03:55 PDT 2023


sbc100 added a comment.

In D147190#4234186 <https://reviews.llvm.org/D147190#4234186>, @dschuff wrote:

> i.e. it seems like it would be simpler to just support processing the stubs once. or maybe more specifically, to handle them the same as other archive libraries (i.e. participate in the iterate-to-convergence phase of symbol resolution but not get special treatment for LTO?)

I think that would require injecting the dependency graph of the stub library into the relocation graph somehow.  I did consider trying to do that but this solution ended up being a lot simpler.   I don't think we need to worry about the cost of processing these stubs, do you?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147190/new/

https://reviews.llvm.org/D147190



More information about the llvm-commits mailing list