[PATCH] D147167: [TwoAddressInstruction] Improve tests for register killed by instruction

Jay Foad via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 30 11:00:38 PDT 2023


foad added a comment.

In D147167#4234159 <https://reviews.llvm.org/D147167#4234159>, @arsenm wrote:

> LGTM. Seems like an error in the kill flag insertion

You mean all uses of reg in one instruction should be marked as killed if any of them are? I did wonder about that but I bet it would require a lot of fixups elsewhere - and hopefully kill flags will go away instead.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147167/new/

https://reviews.llvm.org/D147167



More information about the llvm-commits mailing list