[PATCH] D147241: [AMDGPU][AsmParser] Refine parsing SDWA operands.

Jay Foad via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 30 10:58:41 PDT 2023


foad added a comment.

In D147241#4234177 <https://reviews.llvm.org/D147241#4234177>, @kosarev wrote:

>> Can you say a little bit more than "refine" (here and in other patches)? I can see you capitalised Sdwa and introduced a new SDWAOperand class but what's the bigger picture? I guess the win here is being able to remove some code from `AMDGPUAsmParser.cpp`?
>
> Yes, same as with other similar patches this change removes the need for the custom code in `parseCustomOperand()`. Do you suggest the commit message to say that?

Yes I would like the commit message to have a brief description of the point of the change.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147241/new/

https://reviews.llvm.org/D147241



More information about the llvm-commits mailing list