[PATCH] D147127: [TableGen] Enable "Type set is empty for each HW mode" error in non-debug builds

[Jay Foad via Phabricator via llvm-commits]

foad added inline comments.


================
Comment at: llvm/utils/TableGen/CodeGenDAGPatterns.cpp:890
   if (Infer.Validate && !VTS.validate()) {
-    dbgs() << "Type set is empty for each HW mode:\n"
+#if !defined(NDEBUG) || defined(LLVM_ENABLE_DUMP)
+    errs() << "Type set is empty for each HW mode:\n"
----------------
arsenm wrote:
> Could just move this to limit the part with the dumps and still print the error
We print the error unconditionally in the PrintFatalError call below. The only reason for these errs() is to provide a bit of context for the dump()s.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147127/new/

https://reviews.llvm.org/D147127