[PATCH] D147154: [AMDGPU][GlobalISel] Add codegen support for S_INDIRECT_REG_WRITE_MOVREL_B32_V[9|10|11|12]

Jay Foad via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 30 07:58:04 PDT 2023


foad added inline comments.


================
Comment at: llvm/test/CodeGen/AMDGPU/GlobalISel/inst-select-insert-vector-elt.mir:178
+---
+name: insert_vector_elt_s_s32_v9s32
+legalized: true
----------------
matejam wrote:
> foad wrote:
> > How would these tests fail without your patch?
> The compiler wouldn't select S_INDIRECT_REG_WRITE_MOVREL_B32_V9, but would select S_INDIRECT_REG_WRITE_MOVREL_B32_V16 instead.
Then maybe precommit the tests (no review required) and rebase?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147154/new/

https://reviews.llvm.org/D147154



More information about the llvm-commits mailing list