[PATCH] D146940: [Analysis] Deprecate (Legacy)DivergenceAnalysis

Pierre van Houtryve via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 30 03:47:06 PDT 2023


Pierre-vh added a comment.

In D146940#4232995 <https://reviews.llvm.org/D146940#4232995>, @nikic wrote:

> I'd prefer deleting this code over adding pragmas. There is no need to deprecate things in C++ API before removal.

I thought we needed to deprecate the analysis first if there are downstream users. Is there a precedent for removing an analysis directly without deprecation?
If so, can you please mention it in the RFC? https://discourse.llvm.org/t/rfc-deprecate-divergenceanalysis-legacydivergenceanalysis/69538/4

I'd also rather just delete it now - especially because there's no reason not to use UA, but I thought deprecation was a mandatory step.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146940/new/

https://reviews.llvm.org/D146940



More information about the llvm-commits mailing list