[PATCH] D147159: [AMDGPU][GFX940] Simplify definitions of GLOBAL_ATOMIC

[Mariusz Sikora via Phabricator via llvm-commits]

mariusz-sikora-at-amd added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/FLATInstructions.td:730
 
+defm GLOBAL_ATOMIC_ADD_F64 : FLAT_Global_Atomic_Pseudo<"global_atomic_add_f64", VReg_64, f64>;
+defm GLOBAL_ATOMIC_MIN_F64 : FLAT_Global_Atomic_Pseudo<"global_atomic_min_f64", VReg_64, f64>;
----------------
rampitec wrote:
> I do not understand this. These were only added in gfx90a.
This patch is only removing 'complexity' from gfx940. For gfx90A we still have Real Instruction under SubtargetPredicate = IsGFX90APlus.
I will add test for gfx908.



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147159/new/

https://reviews.llvm.org/D147159