[PATCH] D147031: [MachineCopy] Enhance sub register machine copy propagation

Sergei Barannikov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 30 02:01:10 PDT 2023


barannikov88 added inline comments.


================
Comment at: llvm/lib/CodeGen/MachineCopyPropagation.cpp:555
+  // renamable $rcx = COPY killed renamable $k0
+  // renamable $k1 = COPY renamable $ecx
+  Register CopyDstReg = CopyOperands->Destination->getReg();
----------------
This method is not called for this example (look for "MCP: Copy source does not have sub-register" below).
`$ecx` is a sub-register of `$rcx`, and its sub-register index is `sub_32bit`. `$k0` does not have sub-registers with index `sub_32bit`.
You can check my assertion by removing this code and making sure that the added test still passes.



CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147031/new/

https://reviews.llvm.org/D147031



More information about the llvm-commits mailing list