[PATCH] D147207: [llvm-mc] Fix line_end_with_space.test

Aiden Grossman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 30 01:36:58 PDT 2023


aidengrossman created this revision.
Herald added a project: All.
aidengrossman requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

Currently, this test doesn't test what it was originally intended to
(that lvm-mc doesn't crash when disassembling a line that ends with a
space). This patch readds the space to the input so that this
functionality is actually tested and adds a comment describing what the
test does. The space seems to have been inadvertently removed in
c8d578311473fceb50579906658b0c017ef5b193 and then never added back
in.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D147207

Files:
  llvm/test/tools/llvm-mc/line_end_with_space.test


Index: llvm/test/tools/llvm-mc/line_end_with_space.test
===================================================================
--- llvm/test/tools/llvm-mc/line_end_with_space.test
+++ llvm/test/tools/llvm-mc/line_end_with_space.test
@@ -1 +1,4 @@
+# Test that llvm-mc doesn't crash when disassembling a line that ends with a
+# space.
 RUN: llvm-mc -disassemble %s
+ 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D147207.509573.patch
Type: text/x-patch
Size: 365 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230330/f1e95811/attachment.bin>


More information about the llvm-commits mailing list