[PATCH] D147110: [symbolizer] Treat invalid address as addr2line does

[Serge Pavlov via Phabricator via llvm-commits]

This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGe9c97cf94103: [symbolizer] Additional tests for invalid address handling (authored by sepavloff).

Changed prior to commit:
  https://reviews.llvm.org/D147110?vs=509275&id=509556#toc

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147110/new/

https://reviews.llvm.org/D147110

Files:
  llvm/test/tools/llvm-symbolizer/invalid-input-address.test


Index: llvm/test/tools/llvm-symbolizer/invalid-input-address.test
===================================================================
--- llvm/test/tools/llvm-symbolizer/invalid-input-address.test
+++ llvm/test/tools/llvm-symbolizer/invalid-input-address.test
@@ -14,6 +14,11 @@
 RUN: llvm-symbolizer --obj=%p/Inputs/addr.exe "some text" "some text2" | FileCheck --check-prefix=BAD-INPUT %s
 RUN: llvm-symbolizer --obj=%p/Inputs/addr.exe @%t.rsp | FileCheck --check-prefix=BAD-INPUT %s
 
+# Test bad input in GNU-compatible output mode.
+RUN: llvm-symbolizer --obj=%p/Inputs/addr.exe --output-style=GNU < %t.inp | FileCheck --check-prefix=GNU-BAD-INPUT %s
+RUN: llvm-symbolizer --obj=%p/Inputs/addr.exe --output-style=GNU "some text" "some text2" | FileCheck --check-prefix=GNU-BAD-INPUT %s
+RUN: llvm-symbolizer --obj=%p/Inputs/addr.exe --output-style=GNU @%t.rsp | FileCheck --check-prefix=GNU-BAD-INPUT %s
+
 BAD-INPUT:      some text
 BAD-INPUT-NEXT: some text2
 
@@ -22,5 +27,10 @@
 RUN: llvm-addr2line --obj=%p/Inputs/addr.exe "some text" "some text2" | FileCheck --check-prefix=GNU-BAD-INPUT %s
 RUN: llvm-addr2line --obj=%p/Inputs/addr.exe @%t.rsp | FileCheck --check-prefix=GNU-BAD-INPUT %s
 
+# Test bad input address values for the GNU-compatible version if output mode is LLVM.
+RUN: llvm-addr2line --obj=%p/Inputs/addr.exe --output-style=LLVM < %t.inp | FileCheck --check-prefix=BAD-INPUT %s
+RUN: llvm-addr2line --obj=%p/Inputs/addr.exe --output-style=LLVM "some text" "some text2" | FileCheck --check-prefix=BAD-INPUT %s
+RUN: llvm-addr2line --obj=%p/Inputs/addr.exe --output-style=LLVM @%t.rsp | FileCheck --check-prefix=BAD-INPUT %s
+
 GNU-BAD-INPUT:      ??:0
 GNU-BAD-INPUT-NEXT: ??:0


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D147110.509556.patch
Type: text/x-patch
Size: 1704 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230330/55fba679/attachment.bin>