[PATCH] D146880: Make git ignore core files

[Fangrui Song via Phabricator via llvm-commits]

MaskRay requested changes to this revision.
MaskRay added a comment.
This revision now requires changes to proceed.

In D146880#4226169 <https://reviews.llvm.org/D146880#4226169>, @barannikov88 wrote:

> IMHO .gitignore is for files that are strictly project-related. Everything else should go into local .git/info/exclude.

I agree. `core` looks too special to ignore in the global configuration file.

>> I have accidentally committed a core file once
>
> You might as well have committed any arbitrary file, e.g. 1.txt. This does not mean '*.txt' should end up in .gitignore.
> It is the committers responsibility to check that everything is OK, and there is also a review process.




Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146880/new/

https://reviews.llvm.org/D146880