[lld] f1f6ca5 - [lld][ELF][NFC] Simplify method "Thunk *elf::addThunk()"
Ben Shi via llvm-commits
llvm-commits at lists.llvm.org
Wed Mar 29 20:35:25 PDT 2023
Author: Ben Shi
Date: 2023-03-30T11:35:07+08:00
New Revision: f1f6ca582e2295465e27a79662d6807342abd9dd
URL: https://github.com/llvm/llvm-project/commit/f1f6ca582e2295465e27a79662d6807342abd9dd
DIFF: https://github.com/llvm/llvm-project/commit/f1f6ca582e2295465e27a79662d6807342abd9dd.diff
LOG: [lld][ELF][NFC] Simplify method "Thunk *elf::addThunk()"
Reviewed By: MaskRay
Differential Revision: https://reviews.llvm.org/D147124
Added:
Modified:
lld/ELF/Thunks.cpp
Removed:
################################################################################
diff --git a/lld/ELF/Thunks.cpp b/lld/ELF/Thunks.cpp
index d193fb676142e..37896d9483d1e 100644
--- a/lld/ELF/Thunks.cpp
+++ b/lld/ELF/Thunks.cpp
@@ -1313,20 +1313,18 @@ Thunk *elf::addThunk(const InputSection &isec, Relocation &rel) {
Symbol &s = *rel.sym;
int64_t a = rel.addend;
- if (config->emachine == EM_AARCH64)
+ switch (config->emachine) {
+ case EM_AARCH64:
return addThunkAArch64(rel.type, s, a);
-
- if (config->emachine == EM_ARM)
+ case EM_ARM:
return addThunkArm(rel.type, s, a);
-
- if (config->emachine == EM_MIPS)
+ case EM_MIPS:
return addThunkMips(rel.type, s);
-
- if (config->emachine == EM_PPC)
+ case EM_PPC:
return addThunkPPC32(isec, rel, s);
-
- if (config->emachine == EM_PPC64)
+ case EM_PPC64:
return addThunkPPC64(rel.type, s, a);
-
- llvm_unreachable("add Thunk only supported for ARM, Mips and PowerPC");
+ default:
+ llvm_unreachable("add Thunk only supported for ARM, Mips and PowerPC");
+ }
}
More information about the llvm-commits
mailing list