[PATCH] D147173: [RISCV] Merge SExtWRemoval and StripWSuffix into a single pass.

Wed Mar 29 16:16:58 PDT 2023

asb added a comment.

In D147173#4232034 <https://reviews.llvm.org/D147173#4232034>, @craig.topper wrote:

> In D147173#4231929 <https://reviews.llvm.org/D147173#4231929>, @asb wrote:
>
>> LGTM. I'd note that clang-format prefers different formatting for some of the functions here - it's probably worth reformatting while you're doing this merge into a new pass.
>
> Is it just the switch statement I intentionally wrote with the lines compacted?

There were other instances too, but I ran it after applying D147174 <https://reviews.llvm.org/D147174> so may have been from changed lines there. As for the switch - it's short enough I personally wouldn't bother opting out of clang-format's preferences, but I don't have a problem with it as is.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147173/new/

https://reviews.llvm.org/D147173