[PATCH] D147173: [RISCV] Merge SExtWRemoval and StripWSuffix into a single pass.

Alex Bradbury via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 29 14:01:46 PDT 2023


asb accepted this revision.
asb added a comment.
This revision is now accepted and ready to land.

LGTM. I'd note that clang-format prefers different formatting for some of the functions here - it's probably worth reformatting while you're doing this merge into a new pass.



================
Comment at: llvm/lib/Target/RISCV/RISCVOptWInstrs.cpp:9
 //
-// This pass removes unneeded sext.w instructions at the MI level. Either
-// because the sign extended bits aren't consumed or because the input was
-// already sign extended by an earlier instruction.
+// This pass does a couple optimizations for *W instructions at the MI level.
+//
----------------
couple => couple of


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147173/new/

https://reviews.llvm.org/D147173



More information about the llvm-commits mailing list