[PATCH] D147178: [MachineOutliner] Fix label outlining regression introduced in D125072
duk via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Mar 29 13:12:56 PDT 2023
duck-37 created this revision.
duck-37 added a reviewer: paquette.
Herald added a subscriber: hiraditya.
Herald added a project: All.
duck-37 requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.
Discovered by @zjaffal
Due to a change in the APIs used to determine what instructions can be outlined, the check for label outling was never hit. Instead, all labels were considered invisible, which is the opposite of the intended behavior and causes obscure crashes down the line. We now replicate the original behavior more closely, with explicit checks for known-good and known-bad instruction types.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D147178
Files:
llvm/lib/CodeGen/TargetInstrInfo.cpp
llvm/test/CodeGen/AArch64/machine-outliner-labels.ll
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D147178.509459.patch
Type: text/x-patch
Size: 19879 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230329/3bcafc49/attachment.bin>
More information about the llvm-commits
mailing list