[PATCH] D146858: [msan] Fix handling of ParamTLS overflow.

[Evgenii Stepanov via Phabricator via llvm-commits]

eugenis added inline comments.


================
Comment at: llvm/lib/Transforms/Instrumentation/MemorySanitizer.cpp:5734
+      VAArgTLSCopy->setAlignment(kShadowTLSAlignment);
+      IRB.CreateMemSet(VAArgTLSCopy, Constant::getNullValue(IRB.getInt8Ty()),
+                       CopySize, kShadowTLSAlignment, false);
----------------
vitalybuka wrote:
> should the tail be poisoned instead?
no, the tail is for the arguments whose shadow did not fit in ParamTLS - we have to assume they are good to avoid false positives


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146858/new/

https://reviews.llvm.org/D146858