[PATCH] D145219: [X86][InstCombine] Add tests for simplifying pternlog intrinsics; NFC

Noah Goldstein via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 29 10:37:35 PDT 2023


goldstein.w.n added a comment.

In D145219#4230166 <https://reviews.llvm.org/D145219#4230166>, @RKSimon wrote:

> It'd be useful to add tests to see if the relevant ternlog patterns get correctly canonicalized to the useful patterns listed here: http://www.0x80.pl/articles/avx512-ternary-functions.html
>
> In particular - ensuring we fold ternlog -> bitselect -> regular select (if driven by a compare / sign-extended bool vector), and maybe the one-bit-set pattern are of particular interest?

So we already have tests for one_bit_set/two_bits_set/bitselect just as a function of exhaustive through all `imm` values, but I added carry-save-add and vselect (cmp; sext; bitselect) patterns.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145219/new/

https://reviews.llvm.org/D145219



More information about the llvm-commits mailing list