[PATCH] D145220: [X86][InstCombine] Simplify some `pternlog` intrinsics

Noah Goldstein via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 29 10:37:15 PDT 2023


goldstein.w.n marked an inline comment as done.
goldstein.w.n added inline comments.


================
Comment at: llvm/unittests/Transforms/InstCombine/X86/TernlogTest.cpp:187
+  TernTester TT;
+  for (unsigned NTests = 0; NTests < 1; ++NTests) {
+    for (unsigned NElem = 2; NElem < 16; NElem += NElem) {
----------------
goldstein.w.n wrote:
> pengfei wrote:
> > What is loop used for?
> Because the tests use random values it may make sense to increase number of rand iterations. I can remove if you think its unnecessary.
Removed it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145220/new/

https://reviews.llvm.org/D145220



More information about the llvm-commits mailing list