[PATCH] D143535: github: Add manual workflow to build and upload release binaries

[Tom Stellard via Phabricator via llvm-commits]

tstellar added inline comments.


================
Comment at: .github/workflows/release-binaries.yml:46
+      # | X.Y.Z     | -final
+      run: |
+        if [ -n "${{ inputs.tag }}" ]; then
----------------
kwk wrote:
> 
`bash -e` is the default shell command already.


================
Comment at: .github/workflows/release-binaries.yml:10
+      upload:
+        description: 'Upload binaries to the release page'
+        required: true
----------------
kwk wrote:
> Why is it optional to upload the binaries?
I thought it would be useful for doing test builds that we don't want to end up on the official release page.


================
Comment at: .github/workflows/set-release-binary-outputs.sh:15
+
+test "$github_user" = "tstellar" || test "$github_user" = "tru"
+echo "$tag" | grep -e '^llvmorg-[0-9]\+\.[0-9]\+\.[0-9]\+\(-rc[0-9]\+\)\?$'
----------------
kwk wrote:
> This way the logic is less implicit or bashy and more easy on the eyes IMHO.
I had to change the logic slightly, but I implemented this change.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143535/new/

https://reviews.llvm.org/D143535