[PATCH] D144959: [AMDGPU][AsmParser][NFC] Refine immediate operand definitions.

[Dmitry Preobrazhensky via Phabricator via llvm-commits]

dp added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUInstructions.td:137
+                 string printer = "print"#name> : Operand<type> {
+  AsmOperandClass ParserMatchClass = ImmOperandClass<name, optional>;
+  let PrintMethod = printer;
----------------
kosarev wrote:
> dp wrote:
> > This redefinition is unnecessary, 'let' would suffice.
> Can you elaborate? I'm not sure I understand the suggestion.
It looks like the code
    AsmOperandClass ParserMatchClass = ImmOperandClass<name, optional>;
may be simplified as follows:
    let ParserMatchClass = ImmOperandClass<name, optional>;



================
Comment at: llvm/lib/Target/AMDGPU/SMInstructions.td:750
 
-def smrd_literal_offset : NamedOperandU32<"SMRDLiteralOffset",
-                                          NamedMatchClass<"SMRDLiteralOffset">> {
-  let OperandType = "OPERAND_IMMEDIATE";
-}
+def smrd_literal_offset : ImmOperand<i32, "SMRDLiteralOffset">;
 
----------------
kosarev wrote:
> dp wrote:
> > Shouldn't this operand be optional?
> Nope, `isSMRDLiteralOffset()` doesn't accept zeroes.
Oh I see, thanks.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144959/new/

https://reviews.llvm.org/D144959