[PATCH] D147133: [IPO] Add documentation for new function argument

Shoaib Meenai via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 29 08:37:07 PDT 2023


This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGd33bac18bb77: [IPO] Add documentation for new function argument (authored by smeenai).

Changed prior to commit:
  https://reviews.llvm.org/D147133?vs=509286&id=509382#toc

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147133/new/

https://reviews.llvm.org/D147133

Files:
  llvm/include/llvm/Transforms/IPO/FunctionImport.h


Index: llvm/include/llvm/Transforms/IPO/FunctionImport.h
===================================================================
--- llvm/include/llvm/Transforms/IPO/FunctionImport.h
+++ llvm/include/llvm/Transforms/IPO/FunctionImport.h
@@ -136,6 +136,10 @@
 /// \p ModuleToDefinedGVSummaries contains for each Module a map
 /// (GUID -> Summary) for every global defined in the module.
 ///
+/// \p isPrevailing is a callback that will be called with a global value's GUID
+/// and summary and should return whether the module corresponding to the
+/// summary contains the linker-prevailing copy of that value.
+///
 /// \p ImportLists will be populated with an entry for every Module we are
 /// importing into. This entry is itself a map that can be passed to
 /// FunctionImporter::importFunctions() above (see description there).
@@ -153,6 +157,10 @@
 
 /// Compute all the imports for the given module using the Index.
 ///
+/// \p isPrevailing is a callback that will be called with a global value's GUID
+/// and summary and should return whether the module corresponding to the
+/// summary contains the linker-prevailing copy of that value.
+///
 /// \p ImportList will be populated with a map that can be passed to
 /// FunctionImporter::importFunctions() above (see description there).
 void ComputeCrossModuleImportForModule(


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D147133.509382.patch
Type: text/x-patch
Size: 1336 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230329/489114d8/attachment.bin>


More information about the llvm-commits mailing list