[PATCH] D147134: [RFC][Debugify] Remove false positve debug location losses

[Orlando Cazalet-Hyams via Phabricator via llvm-commits]

Orlando added a comment.

This looks useful and the results in the RFC are promising. I like the approach, however, I worry that adding a field to `Instruction` may be expensive - have you measured the performance and memory usage impact?

It may be that we need to come up with another mechanism for storing this info (nothing concrete comes to mind right now - I'm not terribly familiar with `Instruction`'s internal state; I'm not sure if there are any spare bits hanging around that we might be able to use instead e.g. in SubclassData or something like that).

It seems like a good idea though. Have you managed to find any bugs (or perhaps parts of the compiler that should be marking DebugLocs as dropped) using this yet?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147134/new/

https://reviews.llvm.org/D147134