[PATCH] D147112: [symbolizer] Factor out conversion DILineInfo->JSON. NFC
Serge Pavlov via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Mar 29 08:29:47 PDT 2023
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG90025187f014: [symbolizer] Factor out conversion DILineInfo->JSON. NFC (authored by sepavloff).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D147112/new/
https://reviews.llvm.org/D147112
Files:
llvm/lib/DebugInfo/Symbolize/DIPrinter.cpp
Index: llvm/lib/DebugInfo/Symbolize/DIPrinter.cpp
===================================================================
--- llvm/lib/DebugInfo/Symbolize/DIPrinter.cpp
+++ llvm/lib/DebugInfo/Symbolize/DIPrinter.cpp
@@ -293,6 +293,24 @@
return Json;
}
+static json::Object toJSON(const DILineInfo &LineInfo) {
+ return json::Object(
+ {{"FunctionName", LineInfo.FunctionName != DILineInfo::BadString
+ ? LineInfo.FunctionName
+ : ""},
+ {"StartFileName", LineInfo.StartFileName != DILineInfo::BadString
+ ? LineInfo.StartFileName
+ : ""},
+ {"StartLine", LineInfo.StartLine},
+ {"StartAddress",
+ LineInfo.StartAddress ? toHex(*LineInfo.StartAddress) : ""},
+ {"FileName",
+ LineInfo.FileName != DILineInfo::BadString ? LineInfo.FileName : ""},
+ {"Line", LineInfo.Line},
+ {"Column", LineInfo.Column},
+ {"Discriminator", LineInfo.Discriminator}});
+}
+
void JSONPrinter::print(const Request &Request, const DILineInfo &Info) {
DIInliningInfo InliningInfo;
InliningInfo.addFrame(Info);
@@ -303,21 +321,7 @@
json::Array Array;
for (uint32_t I = 0, N = Info.getNumberOfFrames(); I < N; ++I) {
const DILineInfo &LineInfo = Info.getFrame(I);
- json::Object Object(
- {{"FunctionName", LineInfo.FunctionName != DILineInfo::BadString
- ? LineInfo.FunctionName
- : ""},
- {"StartFileName", LineInfo.StartFileName != DILineInfo::BadString
- ? LineInfo.StartFileName
- : ""},
- {"StartLine", LineInfo.StartLine},
- {"StartAddress",
- LineInfo.StartAddress ? toHex(*LineInfo.StartAddress) : ""},
- {"FileName",
- LineInfo.FileName != DILineInfo::BadString ? LineInfo.FileName : ""},
- {"Line", LineInfo.Line},
- {"Column", LineInfo.Column},
- {"Discriminator", LineInfo.Discriminator}});
+ json::Object Object = toJSON(LineInfo);
SourceCode SourceCode(LineInfo.FileName, LineInfo.Line,
Config.SourceContextLines, LineInfo.Source);
std::string FormattedSource;
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D147112.509380.patch
Type: text/x-patch
Size: 2285 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230329/aa63c1a4/attachment.bin>
More information about the llvm-commits
mailing list