[PATCH] D147145: [AMDGPU] Consistently use v2i16 for packed bf16 inputs. NFC.

[Jay Foad via Phabricator via llvm-commits]

foad added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/FLATInstructions.td:735
   defm FLAT_ATOMIC_PK_ADD_F16    : FLAT_Atomic_Pseudo<"flat_atomic_pk_add_f16",  VGPR_32, v2f16>;
-  defm FLAT_ATOMIC_PK_ADD_BF16   : FLAT_Atomic_Pseudo<"flat_atomic_pk_add_bf16", VGPR_32, v2f16>;
+  let FPAtomic = 1 in
+    defm FLAT_ATOMIC_PK_ADD_BF16   : FLAT_Atomic_Pseudo<"flat_atomic_pk_add_bf16", VGPR_32, v2i16>;
----------------
FPAtomic is usually deduced from the type, so I override it here to ensure NFC.

//However// it is only used by the hazard detection code for "FPAtomicToDenormModeHazard" which is GFX10-only, and GFX10 does not have these instructions, so perhaps I should not bother to override FPAtomic here?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147145/new/

https://reviews.llvm.org/D147145