[PATCH] D147127: [TableGen] Enable "Type set is empty for each HW mode" error in non-debug builds

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/utils/TableGen/CodeGenDAGPatterns.cpp:891
+#ifndef NDEBUG
     dbgs() << "Type set is empty for each HW mode:\n"
               "possible type contradiction in the pattern below "
----------------
Should switch these to errs


================
Comment at: llvm/utils/TableGen/CodeGenDAGPatterns.cpp:897
     dbgs() << "Generated from record:\n";
     Infer.TP.getRecord()->dump();
+#endif
----------------
I thought dumps had a separate macro which was implied by NDEBUG


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147127/new/

https://reviews.llvm.org/D147127