[PATCH] D147137: Extend handlng of fp min/max.

Serguei Katkov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 29 04:07:01 PDT 2023


skatkov added inline comments.


================
Comment at: llvm/lib/Analysis/ValueTracking.cpp:7164
   case Intrinsic::umin: return Intrinsic::umax;
+  case Intrinsic::maximum: return Intrinsic::minimum;
+  case Intrinsic::minimum: return Intrinsic::maximum;
----------------
The documentation for this method does not say whether "inverse" expects that if a != b then max(a, b) != min(a, b).
For new added cases it is not true.

So if it is expected I can create another utility function.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147137/new/

https://reviews.llvm.org/D147137



More information about the llvm-commits mailing list