[PATCH] D147133: [IPO] Add documentation for new function argument

[Shoaib Meenai via Phabricator via llvm-commits]

smeenai created this revision.
smeenai added reviewers: fhahn, tejohnson.
Herald added subscribers: ormris, StephenFan.
Herald added a project: All.
smeenai requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

As pointed out by @fhahn in https://reviews.llvm.org/D146876.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D147133

Files:
  llvm/include/llvm/Transforms/IPO/FunctionImport.h


Index: llvm/include/llvm/Transforms/IPO/FunctionImport.h
===================================================================
--- llvm/include/llvm/Transforms/IPO/FunctionImport.h
+++ llvm/include/llvm/Transforms/IPO/FunctionImport.h
@@ -136,6 +136,10 @@
 /// \p ModuleToDefinedGVSummaries contains for each Module a map
 /// (GUID -> Summary) for every global defined in the module.
 ///
+/// \p isPrevailing is a function-like object that will be called with a global
+/// value's GUID and summary and should return whether the module corresponding
+/// to the summary contains the linker-prevailing copy of that value.
+///
 /// \p ImportLists will be populated with an entry for every Module we are
 /// importing into. This entry is itself a map that can be passed to
 /// FunctionImporter::importFunctions() above (see description there).
@@ -153,6 +157,10 @@
 
 /// Compute all the imports for the given module using the Index.
 ///
+/// \p isPrevailing is a function-like object that will be called with a global
+/// value's GUID and summary and should return whether the module corresponding
+/// to the summary contains the linker-prevailing copy of that value.
+///
 /// \p ImportList will be populated with a map that can be passed to
 /// FunctionImporter::importFunctions() above (see description there).
 void ComputeCrossModuleImportForModule(


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D147133.509286.patch
Type: text/x-patch
Size: 1360 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230329/396cb1c1/attachment.bin>