[PATCH] D146980: [Assignment Tracking] Coalesce dbg loc definitions with contiguous fragments

[Orlando Cazalet-Hyams via Phabricator via llvm-commits]

Orlando updated this revision to Diff 509256.
Orlando added a comment.

+ Check if instr-ref is turned on before coalescing fragments (see true table in coalesce-options.ll)
+ Add test coalesce-options.ll

Note that the check uses `debuginfoShouldUseDebugInstrRef` which misses out the `-O0` and `((optnone))` checks that the `MachineFunction` variation use. Assignment tracking is currently disabled for `-O0` (note to self: we should check `((optnone))` in AssignmentTrackingPass too) but either way locations that require coalescing shouldn't be created if there are no optimisations - so no harm should come of this slightly permissive interpretation of instruction-reference enabled-ness.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146980/new/

https://reviews.llvm.org/D146980

Files:
  llvm/lib/CodeGen/AssignmentTrackingAnalysis.cpp
  llvm/test/DebugInfo/assignment-tracking/X86/coalesce-cfg.ll
  llvm/test/DebugInfo/assignment-tracking/X86/coalesce-options.ll
  llvm/test/DebugInfo/assignment-tracking/X86/coalesce-simple.ll
  llvm/test/DebugInfo/assignment-tracking/X86/lower-to-value.ll
  llvm/test/DebugInfo/assignment-tracking/X86/mem-loc-frag-fill-cfg.ll
  llvm/test/DebugInfo/assignment-tracking/X86/mem-loc-frag-fill.ll
  llvm/test/DebugInfo/assignment-tracking/X86/nested-loop-frags.ll
  llvm/test/DebugInfo/assignment-tracking/X86/use-known-value-at-early-mem-def-2.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D146980.509256.patch
Type: text/x-patch
Size: 33103 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230329/0c4970cf/attachment-0001.bin>