[PATCH] D147126: [NFC]add & to avoid copy

Wang, Xin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 29 02:01:31 PDT 2023


XinWang10 created this revision.
Herald added a subscriber: hiraditya.
Herald added a project: All.
XinWang10 requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

The elements in FragmentMap are big objects, use reference can get
better performance, as someone do in line 1912.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D147126

Files:
  llvm/lib/CodeGen/AssignmentTrackingAnalysis.cpp


Index: llvm/lib/CodeGen/AssignmentTrackingAnalysis.cpp
===================================================================
--- llvm/lib/CodeGen/AssignmentTrackingAnalysis.cpp
+++ llvm/lib/CodeGen/AssignmentTrackingAnalysis.cpp
@@ -1921,7 +1921,7 @@
 
   // Build the map.
   AssignmentTrackingLowering::OverlapMap Map;
-  for (auto Pair : FragmentMap) {
+  for (auto &Pair : FragmentMap) {
     auto &Frags = Pair.second;
     for (auto It = Frags.begin(), IEnd = Frags.end(); It != IEnd; ++It) {
       DIExpression::FragmentInfo Frag = It->getFragmentOrDefault();


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D147126.509257.patch
Type: text/x-patch
Size: 566 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230329/8f8653dc/attachment.bin>


More information about the llvm-commits mailing list