[PATCH] D147040: [AArch64][CodeGen] Use interleave store for streaming compatible functions

David Sherwood via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 29 01:51:45 PDT 2023


david-arm added inline comments.


================
Comment at: llvm/test/CodeGen/AArch64/sve-streaming-mode-fixed-length-shuffle.ll:15
 ; CHECK-NEXT:    mov z0.s, s0
-; CHECK-NEXT:    stp q0, q0, [x0]
 ; CHECK-NEXT:    ret
----------------
Interestingly this code is faster than using `st2w`! That makes me wonder if we're missing some DAG combines somewhere for interleaving stores of splats. It's probably something unlikely to happen in practice though. I don't think you have to do anything in this patch, but it's something we may want to revisit at some point.

I agree with @sdesmalen here - it would be good to have a more generic test case (without splats) here because otherwise this particular test is fragile.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147040/new/

https://reviews.llvm.org/D147040



More information about the llvm-commits mailing list